Visit the Advanced Combat Tracker website
›

Howdy, Stranger!

It looks like you're new here. If you want to get involved, click one of these buttons!

Sign In Register

Quick Links

Categories

In this Discussion

If requesting help, make sure to mention what game you are attempting to use ACT with.
For the best FFXIV support, join Ravahn's Discord Server. Also check out OverlayPlugin's FFXIV FAQ and Setup Guide.

Issue in EQ2 English Parser with attackers and abilities that contain apostrophes and miss

DellmonDellmon
edited August 16 in General ACT Discussion
Hello,

In the current version of the EQ2 English parser, I think there might be an issue the way the parser matches on lines with Player names and an ability which will contain an apostrophe that miss their target.

For example this logged line,
Soandso's unswerving hammer tries to crush Paragon of the Overlord, but Paragon of the Overlord dodges.

When this line is parsed, it creates a unique combatant in the fight called "Sosandso's unswerving hammer".  That unique combatant is parsed with just failed "swings" at the mob.  Successful attacks are credited to the ability (in this case "unswerving hammer") under the proper player's name (in this case, "Soandso").

This occurs for as far as I can tell on any abilities where it misses and contains the string "tries".
For example,
Soandso's aery assassin tries to crush Paragon of the Overlord, but Paragon of the Overlord dodges.
Soandso's shadow tries to crush Paragon of the Overlord, but Paragon of the Overlord dodges the multi attack.


I believe the line where this might be happening is this one from the .CS file
regexArray[3] = new Regex(logTimeStampRegexStr + @"(?<attacker>.+?) (?:try|tries) to (?<attackType>[^ ]+) (?<victimAndSkill>.+?), but (?<why>.+)\.", RegexOptions.Compiled);
Is it as simple of a fix as changing it from "attacker" to "attackerAndSkill" so that attacker and skill string is split on the apostrophe?

If you need any additional information, please let me know.
Thanks for taking a look at this - and - thank you for an amazing tool for EQ2 players!

Halls_of_Fate.Dellmon


Tagged:

Comments

  • EQAdituEQAditu
    Unswerving hammer in this context is not a player skill, but an NPC.  You can see it running around and hitting things.

    The inconsistencies come from the English language and how SoE originally decided to split players and skills.  A side effect is that pets end up looking like player skills in ACT.  Most people would want their pet's damage to be attributed to themselves, so this bug is left as-is.  However for lines where the grammar is not ambiguous, it is attributed to the NPC.

    When the pet attacks: (technically incorrect)
    Aditu's unswerving hammer hits Tin Overseer Omega for a critical of 73331 crushing damage.

    When the pet misses: (technically correct)
    Aditu's unswerving hammer tries to crush Tin Overseer Omega, but misses.

    When the pet uses a skill: (technically incorrect)
    Aditu's unswerving hammer's Unswerving Faith hits Tin Overseer Omega for a critical of 73908990 poison damage.

    When the pet's skill fails: (technically correct)
    Tuix's Ring of Fire tries to burn an Innovative scanner with Flames, but an Innovative scanner resists.

    When the pet takes damage: (technically correct)
    Dysperitia hits Kenlow's shadow for 208614408 disease damage.

    For bonus apostrophes, a pet healing: (technically incorrect)
    Aditu's unswerving hammer's Vengeance heals Aditu's unswerving hammer for 971 hit points.
    Solange's Lunar Attendant's Oracle's Blessing heals YOU for 2018 hit points.
    Roxylee's Faerie Ally's Faerie Aid heals Kenlow's shadow for 10 hit points.

    You can see how often the combatant and skill name cross the boundary of the entity name.  Ironically, the instance that you're finding fault in is technically correct.
Sign In or Register to comment.